Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NULL handling in get paths #296

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

darshanasbg
Copy link
Contributor

Proposed changes in this pull request

$subject. Improving,

When should this PR be merged

Immediate

Follow up actions

N/A

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 30.40%. Comparing base (97740cd) to head (3d76a91).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 0.00% 9 Missing ⚠️
...carbon/email/mgt/store/DBBasedTemplateManager.java 0.00% 6 Missing ⚠️
...o/cache/CacheBackedOrgNotificationTemplateDAO.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
- Coverage     31.43%   30.40%   -1.04%     
- Complexity      468      492      +24     
============================================
  Files            72       72              
  Lines          4784     5055     +271     
  Branches        609      658      +49     
============================================
+ Hits           1504     1537      +33     
- Misses         3128     3362     +234     
- Partials        152      156       +4     
Flag Coverage Δ
unit 15.90% <0.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg merged commit 877a1b6 into wso2-extensions:master Dec 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants