Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store notification content as binary to support unicode #280

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

darshanasbg
Copy link
Contributor

@darshanasbg darshanasbg commented Nov 11, 2024

Proposed changes in this pull request

$subject. Related to,

When should this PR be merged

After merging,

Follow up actions

When updating product-is versions, both the framework change and this should be update together.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 17.00%. Comparing base (5cba885) to head (4298c19).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../org/wso2/carbon/email/mgt/util/I18nEmailUtil.java 0.00% 16 Missing ⚠️
...mail/mgt/store/dao/AppNotificationTemplateDAO.java 0.00% 14 Missing ⚠️
...mail/mgt/store/dao/OrgNotificationTemplateDAO.java 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
- Coverage     17.11%   17.00%   -0.12%     
  Complexity      180      180              
============================================
  Files            53       53              
  Lines          3027     3047      +20     
  Branches        332      333       +1     
============================================
  Hits            518      518              
- Misses         2467     2487      +20     
  Partials         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@darshanasbg darshanasbg requested a review from Copilot November 19, 2024 16:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 suggestions.

Files not reviewed (1)
  • pom.xml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants