Introduce application specific email templates #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avarjana
force-pushed
the
email-templates-v2
branch
from
312cb5e to
cb75f5a
Compare
1 task
Avarjana
commented
Feb 28, 2024
| } | ||
|
|
||
| @Override | ||
| public void addNotificationTemplateType(String displayName, String notificationChannel, |
There was a problem hiding this comment.
Check if email template interface can be a direct extension point from notification
....wso2.carbon.email.mgt/src/main/java/org/wso2/carbon/email/mgt/EmailTemplateManagerImpl.java
Show resolved
Hide resolved
....wso2.carbon.email.mgt/src/main/java/org/wso2/carbon/email/mgt/EmailTemplateManagerImpl.java
Show resolved
Hide resolved
....wso2.carbon.email.mgt/src/main/java/org/wso2/carbon/email/mgt/EmailTemplateManagerImpl.java
Outdated
Show resolved
Hide resolved
...2.carbon.email.mgt/src/test/java/org/wso2/carbon/email/mgt/ApplicationEmailTemplateTest.java
Show resolved
Hide resolved
...2.carbon.email.mgt/src/test/java/org/wso2/carbon/email/mgt/ApplicationEmailTemplateTest.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/event/handler/notification/util/NotificationUtil.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/event/handler/notification/util/NotificationUtil.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8170916834
AnjanaSamindraPerera
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce application UUID to the following methods to cater application specific email templates in EmailTemplateManager.
Application email template resolving for notification handler is also added here.
Related issue
Todo
identity-governanceversion from Introduce application specific notification templates identity-governance#811