Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricts if carbon.super added to URL when relevant config is disabled #244

Closed
wants to merge 3 commits into from
Closed

Restricts if carbon.super added to URL when relevant config is disabled #244

wants to merge 3 commits into from

Conversation

Thisara-Welmilla
Copy link
Contributor

Related issue:

Restrict if carbon.super is appended to the URL, when the tenant qualified URL enabled and appendSupertTenantInURL configuration is disabled and vice versa.

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-tenant-qualified-URL branch from 8c3f758 to 46c415d Compare October 11, 2023 06:10
@Thisara-Welmilla Thisara-Welmilla mentioned this pull request Oct 11, 2023
Closed
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-tenant-qualified-URL branch from 46c415d to 1435682 Compare October 11, 2023 06:30
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-tenant-qualified-URL branch from 1435682 to 93fe89c Compare October 19, 2023 11:04
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-tenant-qualified-URL branch from 93fe89c to d00041b Compare October 20, 2023 06:00
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6610666091

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6610666091
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6610705580

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6610705580
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-tenant-qualified-URL branch from a341e03 to 1a073c4 Compare October 23, 2023 09:12
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6611184257

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6611184257
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6635837686

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6635837686
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 25, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6635837686

@ImalshaG ImalshaG mentioned this pull request Oct 26, 2023
Closed
@Thisara-Welmilla
Copy link
Contributor Author

It is decided to not do this inbound restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thisara-Welmilla @jenkins-is-staging