Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO message header support #9

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Conversation

JananiKugaa
Copy link
Contributor

Purpose

The current Implementation doesn't support the message with different header length

Goals

Implement the connector to support iso8583 message with header

Approach

Get encoded header in the XML format message

User stories

Release note

Documentation

Training

Certification

Marketing

Automation tests

Security checks

Samples

Related PRs

Migrations (if applicable)

Test environment

JDK versions-1.8
Operating systems-Ubuntu 16.04
Product- EI-6.1.1

praminda and others added 2 commits December 21, 2017 09:05
This requires headerLength attribute to be present in isoPackager
element in ${WSO2_HOME}/jposdef.xml
*/
private static void handleException(String msg, Exception e) {
throw new SynapseException(msg, e);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line here.

import org.jpos.iso.ISOException;
import org.jpos.iso.ISOPackager;
import org.jpos.iso.packager.GenericPackager;


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is unnecessary. Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -29,4 +32,29 @@ public static ISOPackager getPackager() throws ISOException {
packager = new GenericPackager(ISO8583Constant.PACKAGER);
return packager;
}

public static ISOBasePackager getPackager(int headerLength) {
Copy link
Contributor

@menakaj menakaj Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Javadoc comments for methods.

@menakaj menakaj merged commit 08b1053 into wso2-extensions:master Jan 8, 2018
@JananiKugaa JananiKugaa mentioned this pull request Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants