Support headers with different header length #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameeragunarathne
approved these changes
Jan 29, 2018
menakaj
reviewed
Jan 29, 2018
| @@ -19,5 +19,6 @@ | |||
| <template xmlns="http://ws.apache.org/ns/synapse" name="sendMessage"> | |||
| <sequence> | |||
| <class name="org.wso2.carbon.connector.iso8583.ISO8583MessageProducer"/> | |||
| <script language="js"><![CDATA[mc.getEnvelope().getBody().getFirstElement().detach();]]></script> | |||
| </sequence> | |||
| </template> | |||
There was a problem hiding this comment.
Shall we add a new line here?
muthulee
suggested changes
Jan 30, 2018
| if ((message = inFromServer.readLine()) != null) { | ||
| unpackResponse(messageContext, message); | ||
| } | ||
| Thread.sleep(200); |
There was a problem hiding this comment.
It will take time to get the response from the back end in the input stream buffer. That's why I put.
| try { | ||
| outStream = new DataOutputStream(connection.getOutputStream()); | ||
| inFromServer = new BufferedReader(new InputStreamReader(connection.getInputStream())); | ||
| inFromServer = new DataInputStream(connection.getInputStream()); |
There was a problem hiding this comment.
Furthermore it is wrong to close connection in this finally block. It should be closed by the method who creates it in it's finally block.
Close the socket connection where it was created, in it's finally block. Read the byte from input stream with out sleep the thread.
muthulee
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
support the message with the different header length
Goals
Implement the connector to support iso8583 message with header
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
JDK versions-1.8
Operating systems-Ubuntu 16.04
Product- EI-6.1.1