Eslint

[retorquere]

builds on #103 -- if so desired, I can rebase onto #102 after that has been merged.

[retorquere]

This has now been updated to master. The eslint config makes sure there's a consistent coding style, but will also flag problems like functions being undefind, vars being unused, etc. I've not enabled. There's still two eslint errors that I don't know how to deal with in bootstrap.js, but I don't know what those variables do, so I don't want to touch them.

[retorquere]

I'd usually also turn on no-var because the var scoping rules are so strange, but I'll leave that to you to decide.

[wshanks]

What steps did you use to produce these changes? eslint --fix plus some manual fixes for other issues flagged by eslint? Anything else? I am pretty behind on JS tooling -- the last thing I had been using was jscs which it seems was folded into eslint several years ago.

[retorquere]

Exactly that - eslint --fix and then manual fixes. There's two remaining eslint complaints that I don't know how to deal with because I don't know where those constants are used/introduced.

[wshanks]

What about the .xul files? Were those formatted with a different tool? It seems the & references to strings in the .dtd file were stripped out. Also, Zotero does not like the blank lines at the top.

[retorquere]

Those were done with xmllint -- sorry about that. I've reset them to the upstream master

[wshanks]

The only changes to your branch that I made were to substitute tabs for spaces in the .xul files and squash the commits.

I feel like there is probably a way to feed the .dtd file into xmllint, but I couldn't figure it out playing with the different dtd arguments.

[bjohas]

Thank you!

[retorquere]

@willsALMANJ you can feed the dtd, but it'd probably replace them with their content as it reformats them.

[wshanks]

FYI: I made a new release with all the recent changes, plus shortcuts for the new functions. I did some other non-functional changes to clean up the code like removing old code related to Firefox features, addons.mozilla.org hosting, and Zotero 4 support.