Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖋: 学習コンテンツにビルドの仕組み説明を追加 #178

Merged
merged 7 commits into from
Apr 20, 2021

Conversation

takei0w0
Copy link

@takei0w0 takei0w0 commented Apr 16, 2021

✅ What's done

  • RN学習のGettingStartedにビルドの仕組みについてかんたんに説明を記載
  • 説明用の図を追加

@github-actions github-actions bot added the doc Improvements or additions to documentation label Apr 16, 2021
@takei0w0 takei0w0 enabled auto-merge (squash) April 16, 2021 09:38
Copy link

@in-a-paddy in-a-paddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android/iOSのロゴがちょっと気になっちゃったのと、build&install, loadのあたりが少し読み取りづらいかな、と。
あと、ロード元がブラウザっぽいアイコンになってるから、アプリっぽいのにしたいなぁ、と。

buildは端末内に、installの矢印とloadの矢印は上下を逆にしたほうがいいかな、と思った。あと、loadは Load JSとかにしたほうがいいかも
Build App → Install App → Load JS in App の順番が自然にわかるような図になっていると良いなぁ、と。

@takei0w0 takei0w0 merged commit 3b39e05 into master Apr 20, 2021
@takei0w0 takei0w0 deleted the feature/build-description branch April 20, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants