Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️: Update to Node 20 #1290

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

sinho-lee
Copy link

@sinho-lee sinho-lee commented Nov 9, 2023

✅ What's done

  • Nodeのバージョンアップ(v18.15.0 → v20.9.0)
  • Nodeバージョンアップによるpackage-lock.jsonファイルを更新 (対応Commit: 56d9491)
  • GitHub Actionsで利用するNode.jsのバージョンを修正 (対応Commit: c528866)
  • Azure Pipelinesで利用するNode.jsのバージョンを修正 (対応Commit: bae1111)
  • Fintanコンテンツの開発環境の構築ページのNodeバージョンを修正 (対応Commit: c2da102)
  • FintanコンテンツのExpo SDK 49アップグレードページのNodeバージョンを追記 (対応Commit: ee66363)

Tests

  • npmに関するコマンドの実行
    • npm run test
    • npm ci
    • npm run prebuild
    • npm run pod-install

Other (messages to reviewers, concerns, etc.)

なし

@sinho-lee sinho-lee added dependencies Pull requests that update a dependency file build labels Nov 9, 2023
@github-actions github-actions bot added the chore Other changes that don't modify src or test files. label Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙅 GitHub ActionsとAzure Pipelinesで利用するNode.jsのバージョンも修正をお願いします。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応Commit

@github-actions github-actions bot added ci Changes to CI configuration files and scripts (GitHub Actions etc.) doc Improvements or additions to documentation labels Nov 14, 2023
@sinho-lee sinho-lee marked this pull request as draft November 19, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Other changes that don't modify src or test files. ci Changes to CI configuration files and scripts (GitHub Actions etc.) dependencies Pull requests that update a dependency file doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants