Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #1

Closed
4 tasks done
Infernio opened this issue Sep 17, 2020 · 4 comments
Closed
4 tasks done

Tests #1

Infernio opened this issue Sep 17, 2020 · 4 comments
Assignees
@Infernio
Labels
C-goal Category: Long term goal. May be code-related or a meta goal.

Comments

@Infernio
Copy link
Member

Infernio commented Sep 17, 2020 •
edited
Loading

wizparse should have tests and a CI - once we merge it back into WB, we'll want to carry those tests forward. Might also help other projects out.

  • A set of working tests -> done in 5f5af96, could always use more though
  • Add Beermotor's tests -> done in a0ae64a
  • A set of failing tests (to test the breaking changes and other things we don't want to support) -> done in a0ae64a
  • Add some links to proprietary wizards so that people can locally test -> done in a0ae64a
@Infernio Infernio self-assigned this Sep 17, 2020
@Infernio
Copy link
Member Author

@BeermotorWB In case you see it here - could you give us explicit permission to redistribute your BAIN wizards on https://www.afkmods.com/index.php?/topic/4987-relz-mertzs-wizbain-thread/ for CI/testing the new parser? Best to do it in a post on that thread so that we can archive and link it.

Infernio added a commit that referenced this issue Sep 17, 2020
@Infernio
Merge branch 'inf-1-initial-tests' into master
5f5af96 
Turns out a lot of wizards are under all rights reserved or under
'permissive' systems that just *barely* exclude our use case.

Nexus permissions we need to use a wizard for testing:
 - Other user's assets (or the wizard needs to be one of the allowed
   assets)
 - Upload permission
 - Asset use permission

The rest aren't important - we're not going to modify the wizard, we
won't 'convert' it (which is really just modifying - weird permission
system), we're not selling wizparse and we don't earn any DP for it
either. Of course the whole thing can be overruled by Author notes or
explicit permission given elsewhere.

Under #1
@BeermotorWB
Copy link

@Infernio sorry I'm just now seeing this. Yes you guys always have my permission to use/distribute these and they are completely open source.

I've published all of these on my Google Drive:

https://drive.google.com/drive/folders/1fIyAa3zV2X1QKWPdcSIwTklo1dQ71Kk2?usp=sharing

@Infernio
Copy link
Member Author

Thanks 👍

@Infernio Infernio mentioned this issue Oct 27, 2020
Open
@Infernio Infernio added the C-goal Category: Long term goal. May be code-related or a meta goal. label Oct 28, 2020
Infernio added a commit that referenced this issue Nov 17, 2020
@Infernio
Merge branch 'inf-1-beermotor-tests' into dev
a0ae64a 
This merge adds in @BeermotorWB's tests, as well as a bunch of failing
tests to track our breaking changes.

Under #1
@Infernio
Copy link
Member Author

Whoops, that commit should have closed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Infernio Infernio

Labels
C-goal Category: Long term goal. May be code-related or a meta goal.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Infernio @BeermotorWB