Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rest of my changes for G731GW #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Nov 28, 2019

  1. Update logging.

    Report errors if sending any of the messages fails (although it never seems to).
    
    Add verbose printing for the SET and APPLY messages.
    
    Add newlines to some errors and verbose logs.
    JoshDreamland committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    06616d9 View commit details
    Browse the repository at this point in the history
  2. Add brightness controls.

    Refactor argument parsing to allow different kinds of scalars (not just speed).
    Define brightness as a scalar type and expose a feature to set the brightness dynamically. This feature is completely necessary to operate this tool on some systems, where the brightness is reset to zero as soon as GRUB is loaded.
    Does some other minor tweaking that adds little value but is generally unobjectionable.
    JoshDreamland committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    e9bdfbb View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Redo arguments. Add rainbow/pulsing effects.

    Rewrites argument storage to handle colors and scalars with a tagged union.
    
    Unifies an argument descriptor to set these apart in function records.
    
    Adds default argument values and allows handlers to ignore an inapplicable argument string when a default value is set. Assigns defaults when insufficient arguments are specified.
    
    Built-in rainbow effect now takes an optional SPEED argument.
    
    single_breathing now sets COLOR2 and SPEED to optional. COLOR2 defaults to COLOR1. SPEED defaults to Medium.
    
    Adds a few more color values and allows passing color names instead of hex strings.
    
    Allows specifying Low/Medium/High for speed and brightness. Also allows argument-specific constants like slow and fast, or dim and bright.
    JoshDreamland committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    6cee846 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Configuration menu
    Copy the full SHA
    cf5c2f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2019

  1. Configuration menu
    Copy the full SHA
    76c91c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Configuration menu
    Copy the full SHA
    ff8f3ff View commit details
    Browse the repository at this point in the history