-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The rest of my changes for G731GW #26
Open
JoshDreamland
wants to merge
6
commits into
wroberts:master
Choose a base branch
from
JoshDreamland:retool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 28, 2019
-
Report errors if sending any of the messages fails (although it never seems to). Add verbose printing for the SET and APPLY messages. Add newlines to some errors and verbose logs.
Configuration menu - View commit details
-
Copy full SHA for 06616d9 - Browse repository at this point
Copy the full SHA 06616d9View commit details -
Refactor argument parsing to allow different kinds of scalars (not just speed). Define brightness as a scalar type and expose a feature to set the brightness dynamically. This feature is completely necessary to operate this tool on some systems, where the brightness is reset to zero as soon as GRUB is loaded. Does some other minor tweaking that adds little value but is generally unobjectionable.
Configuration menu - View commit details
-
Copy full SHA for e9bdfbb - Browse repository at this point
Copy the full SHA e9bdfbbView commit details
Commits on Nov 29, 2019
-
Redo arguments. Add rainbow/pulsing effects.
Rewrites argument storage to handle colors and scalars with a tagged union. Unifies an argument descriptor to set these apart in function records. Adds default argument values and allows handlers to ignore an inapplicable argument string when a default value is set. Assigns defaults when insufficient arguments are specified. Built-in rainbow effect now takes an optional SPEED argument. single_breathing now sets COLOR2 and SPEED to optional. COLOR2 defaults to COLOR1. SPEED defaults to Medium. Adds a few more color values and allows passing color names instead of hex strings. Allows specifying Low/Medium/High for speed and brightness. Also allows argument-specific constants like slow and fast, or dim and bright.
Configuration menu - View commit details
-
Copy full SHA for 6cee846 - Browse repository at this point
Copy the full SHA 6cee846View commit details
Commits on Dec 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cf5c2f4 - Browse repository at this point
Copy the full SHA cf5c2f4View commit details
Commits on Dec 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 76c91c7 - Browse repository at this point
Copy the full SHA 76c91c7View commit details
Commits on Sep 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ff8f3ff - Browse repository at this point
Copy the full SHA ff8f3ffView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.