Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add furo theme on sphinx-themes #2005

Merged
merged 1 commit into from
Aug 14, 2023
Merged

add furo theme on sphinx-themes #2005

merged 1 commit into from
Aug 14, 2023

Conversation

EFord36
Copy link
Contributor

@EFord36 EFord36 commented Aug 14, 2023

Hi,

I saw a suggestion to open PRs with sphinx themes at https://www.writethedocs.org/guide/tools/sphinx-themes/:

These are the Sphinx themes that we recommend. If there are any others you like, feel free to open a pull request to add them.

I've been using furo for my project (kazu, docs here) for a while now and really like it - I thought the least I could do in return was this PR to publicise.

More justification:

The theme is Used by urllib, attrs, pip, python developer's guide, black

I also see it mentioned in this issue: #1516 :

  • what do people think about themes?

    • furo

Which I interpret as probably a suggestion that furo should be included on this page (but the notes are raw, so I may be wrong here).

I'm not overly attached to the wording (or the screenshot in particular!), and I'm not a developer of the theme, so feel free to amend, I just thought I'd start the ball rolling on getting it included here.

I previewed locally and it looked fine to me.


📚 Documentation preview 📚: https://writethedocs-www--2005.org.readthedocs.build/

@ericholscher ericholscher merged commit 7b77281 into writethedocs:main Aug 14, 2023
4 of 5 checks passed
@ericholscher
Copy link
Member

Thanks! Love Furo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants