Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tooltip #366

Closed
wants to merge 1 commit into from
Closed

feat: add tooltip #366

wants to merge 1 commit into from

Conversation

oandalib
Copy link
Contributor

@oandalib oandalib commented Apr 1, 2024

This commit adds tooltip feature per #291.

Recording.2024-04-01.020452.mp4

@FabienArcellier
Copy link
Collaborator

FabienArcellier commented Apr 1, 2024 •
edited
Loading

Many thanks, that looks promising

@oandalib could you run npm install to generate the package-lock.json ? You add a library but it has not been locked as a dependency. It should solve the current error message you have in the continuous integration.

@FabienArcellier
Copy link
Collaborator

We take time to merge this one, because we have discussion about adding floating-vue as an external dependency. We currently try to avoid external css dependencies when we can.

@oandalib oandalib closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raaymax raaymax Awaiting requested review from raaymax

@ramedina86 ramedina86 Awaiting requested review from ramedina86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oandalib @FabienArcellier