Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resultant kwarg so intensity and tune test are more flexible #70

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Oct 17, 2019

Found while adding array detector support for PyCMDS tune test module

@ghost
Copy link

ghost commented Oct 17, 2019

DeepCode Report (#c4e8d8)

DeepCode analyzed this pull request.
There are no new issues.

@ksunden ksunden added the bug label Oct 17, 2019
@ksunden ksunden added this to the 0.2.0 milestone Oct 17, 2019
@ksunden
Copy link
Member Author

ksunden commented Oct 17, 2019

Looks like I need to look into this a bit more... yay for tests...

@ksunden
Copy link
Member Author

ksunden commented Oct 17, 2019

Maybe the change to _intensity just needs to be reverted, I did both because they are so similar, but I will look at it closer

@ksunden
Copy link
Member Author

ksunden commented Oct 18, 2019

CI-fail fixed by wright-group/WrightTools#928

@ksunden
Copy link
Member Author

ksunden commented Nov 1, 2019

@untzag should we do a WT release so we get green CI here?

Tests do pass locally on WT-master

@ksunden
Copy link
Member Author

ksunden commented Nov 8, 2019

@untzag With the WT release 3.2.5, the tests are indeed passing on Travis... Appveyor seems to be having other issues, not sure what's up there, but it's failing almost immediately, not as a result of actual test failures.

My disposition is merge, and address the appveyor failures in a separate PR

@untzag untzag merged commit 474f1e7 into master Nov 8, 2019
@untzag untzag deleted the resultant_kwarg branch November 8, 2019 17:51
ksunden added a commit that referenced this pull request Nov 8, 2019
Needed to enable #70, forgot to bump it there
@ksunden ksunden mentioned this pull request Nov 8, 2019
untzag pushed a commit that referenced this pull request Nov 19, 2019
Needed to enable #70, forgot to bump it there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants