Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holistic #58

Merged
merged 17 commits into from
Oct 7, 2019
Merged

holistic #58

merged 17 commits into from
Oct 7, 2019

Conversation

untzag
Copy link
Member

@untzag untzag commented Jun 2, 2019

function derived from TOPAS preamp tuning

@untzag untzag added this to the 0.0.1 milestone Jun 2, 2019
@untzag untzag self-assigned this Jun 2, 2019
@ksunden
Copy link
Member

ksunden commented Jun 2, 2019

This pull request introduces 3 alerts when merging 8c5e463 into 56a85f9 - view on LGTM.com

new alerts:

  • 1 for Constant in conditional expression or statement
  • 1 for Unused import
  • 1 for Unreachable code

Comment posted by LGTM.com

@ksunden
Copy link
Member

ksunden commented Jun 2, 2019

This pull request introduces 5 alerts when merging 40148e8 into 56a85f9 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Mismatch in multiple assignment
  • 1 for Constant in conditional expression or statement
  • 1 for Unreachable code

Comment posted by LGTM.com

@ksunden
Copy link
Member

ksunden commented Jun 3, 2019

Data file updated using wright-group/WrightTools#909. Simply called from_PyCMDS and save, no stripping of variables (only one channel to begin with)

@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2019

This pull request introduces 5 alerts when merging d69909d into 56a85f9 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Mismatch in multiple assignment
  • 1 for Constant in conditional expression or statement
  • 1 for Unreachable code

@untzag untzag modified the milestones: 0.1.0, 0.2.0 Jun 27, 2019
@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2019

This pull request introduces 4 alerts when merging 95e2422 into bbc03ef - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Constant in conditional expression or statement
  • 1 for Unreachable code

@ghost
Copy link

ghost commented Sep 17, 2019

DeepCode Report (#81716c)

DeepCode analyzed this pull request.
There are 4 new info reports.

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2019

This pull request introduces 5 alerts when merging 23164af into 3e28412 - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 1 for Constant in conditional expression or statement
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2019

This pull request introduces 1 alert when merging 24516be into 3e28412 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@ksunden
Copy link
Member

ksunden commented Sep 18, 2019

I did some blackening in here... Probably should have held off, luckily only one other PR is open

@lgtm-com
Copy link

lgtm-com bot commented Sep 19, 2019

This pull request introduces 4 alerts when merging a7b8ca3 into 3e28412 - view on LGTM.com

new alerts:

  • 4 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2019

This pull request introduces 4 alerts when merging 28613e9 into 3e28412 - view on LGTM.com

new alerts:

  • 4 for Unused import

@ksunden
Copy link
Member

ksunden commented Sep 24, 2019

Tests are failing due to wright-group/WrightTools#923 not being in the released version, tests pass on current master WT (at least locally)

@ksunden ksunden marked this pull request as ready for review September 24, 2019 15:40
@ksunden
Copy link
Member

ksunden commented Oct 4, 2019

@darienmorrow Have you had a chance to see if this is usable/makes sense?

@darienmorrow
Copy link
Member

@ksunden I have briefly perused the PR and used holistic on my OSX machine.

I think we should merge this PR.

@untzag untzag merged commit c71ff6a into master Oct 7, 2019
@untzag untzag deleted the holistic branch October 7, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants