Added everything for Step 10: Implement “Lazy Loading”

wridgeu · Apr 3, 2020 · 8d6ecce · 8d6ecce
1 parent 6419bb0
commit 8d6ecce
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 2 deletions.
diff --git a/webapp/controller/employee/Resume.controller.js b/webapp/controller/employee/Resume.controller.js
@@ -33,6 +33,12 @@ sap.ui.define([
 			oQuery = oArgs["?query"];
 			if (oQuery && _aValidTabKeys.indexOf(oQuery.tab) > -1) {
 				oView.getModel("view").setProperty("/selectedTabKey", oQuery.tab);
+				// support lazy loading for the hobbies and notes tab
+				if (oQuery.tab === "Hobbies" || oQuery.tab === "Notes"){
+					// the target is either "resumeTabHobbies" or "resumeTabNotes"
+					this.getRouter().getTargets().display("resumeTab" + oQuery.tab);
+				}
+
 			} else {
 				// the default query param should be visible at all time
 				this.getRouter().navTo("employeeResume", {

diff --git a/webapp/manifest.json b/webapp/manifest.json
@@ -142,6 +142,22 @@
 					"viewName": "employee.Resume",
 					"viewLevel": 4,
 					"transition": "flip"
+				},
+				"resumeTabHobbies": {
+					"viewId": "resumeHobbies",
+					"parent": "employeeResume",
+					"viewPath": "com.mrb.UI5-Navigation-and-Routing.view.employee",
+					"viewName": "ResumeHobbies",
+					"controlId": "hobbiesTab",
+					"controlAggregation": "content"
+				},
+				"resumeTabNotes": {
+					"viewId": "resumeNotes",
+					"parent": "employeeResume",
+					"viewPath": "com.mrb.UI5-Navigation-and-Routing.view.employee",
+					"viewName": "ResumeNotes",
+					"controlId": "notesTab",
+					"controlAggregation": "content"
 				}
 			}
 		}

diff --git a/webapp/view/employee/Resume.view.xml b/webapp/view/employee/Resume.view.xml
@@ -12,10 +12,10 @@
                         <mvc:XMLView viewName="com.mrb.UI5-Navigation-and-Routing.view.employee.ResumeProjects"></mvc:XMLView>
                     </IconTabFilter>
                     <IconTabFilter id="hobbiesTab" text="{i18n>tabHobbies}" key="Hobbies">
-                        <Text text="{Hobbies}"/>
+                        <!-- place content via lazy loading OLD: <Text text="{Hobbies}"/>-->
                     </IconTabFilter>
                     <IconTabFilter id="notesTab" text="{i18n>tabNotes}" key="Notes">
-                        <Text text="{Notes}"/>
+                         <!-- place content via lazy OLD: <Text text="{Notes}"/>-->
                     </IconTabFilter>
                 </items>
             </IconTabBar>

diff --git a/webapp/view/employee/ResumeHobbies.view.xml b/webapp/view/employee/ResumeHobbies.view.xml
@@ -0,0 +1,3 @@
+<mvc:View xmlns="sap.m" xmlns:mvc="sap.ui.core.mvc">
+	<Text text="{Hobbies}"/>
+</mvc:View>
diff --git a/webapp/view/employee/ResumeNotes.view.xml b/webapp/view/employee/ResumeNotes.view.xml
@@ -0,0 +1,3 @@
+<mvc:View xmlns="sap.m" xmlns:mvc="sap.ui.core.mvc">
+	<Text text="{Notes}"/>
+</mvc:View>