Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "color" field to a task, that is exported to JSON, and displayed by the dashboard code #163

Closed
henricasanova opened this issue May 3, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@henricasanova
Copy link
Contributor

As I am developing Pedagogic Modules that display Gantt charts of tasks executions, it's occurring to me that all tasks being the same color in the Gantt chart doesn't make for the best experience for students. This is especially true for DAGs with dependencies. Hovering over all rectangles to find out which task it is is not ideal. Here is a proposal:

  • We add a "std::string color" field to wrench::WorkflowTask
  • We add setColor()/getColor() methods (with values like "#rrggbb")
  • When exporting the JSON for a task, we output the color ("" if none)
  • The dashboard code, when plotting the task rectangles, plots it with the default color if color="", or with the requested color

This seems really straightforward to me, but I may be wrong. I've assigned all the relevant people to this issue to that you all can comment if you think it's not feasible or not a good idea

@henricasanova henricasanova added this to the 1.7 milestone May 3, 2020
@rafaelfsilva rafaelfsilva modified the milestones: 1.7, 1.6 May 7, 2020
henricasanova added a commit that referenced this issue May 7, 2020
Implemented task colors in the dashboard
henricasanova added a commit that referenced this issue May 7, 2020
Updated JSON commenting
henricasanova added a commit that referenced this issue May 7, 2020
test fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants