Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Simulation Timestamps and JSON output #154

Closed
5 tasks done
henricasanova opened this issue Apr 3, 2020 · 4 comments
Closed
5 tasks done

Enhancements to Simulation Timestamps and JSON output #154

henricasanova opened this issue Apr 3, 2020 · 4 comments
Assignees
Milestone

Comments

@henricasanova
Copy link
Contributor

henricasanova commented Apr 3, 2020

  • Add the file name to the "read" element of the JSON output (since the corresponding TimeStamp has the file)
  • Add a DiskReadStart/End and DiskWriteStart/End TimeStamp, and generate them in S4U_Simulation.cpp (see "TODO" comments therein)
  • Add a "disks" section to the JSON with data from the above timestamp (num bytes, host, disk path)
  • Enhance the SimulationOutput API so that one must enable various "categories" of time-stamps.
  • Make sure Doxygen document for all the "dump JSON" methods is up-to-date
@willkoch
Copy link
Contributor

willkoch commented Apr 6, 2020

File IDs added to read/write

henricasanova added a commit that referenced this issue Apr 8, 2020
Some fixes to the CMakeList.txt
API changes for timestamps (#154)
@henricasanova
Copy link
Contributor Author

Modified the API so that timestamp constructors are now private, and instead a number of addTimestamp...() methods have been added to SimulationOutput. After tinkering with heavily templated complicated design, went for simple.

New methods added to enable/disable timestamp generation at the user-level. By default, all currently available timestamps are enabled, but likely the upcoming disk-related timestamps will not. Look in the constructor SimulationOutput::SimulationOutput() where the default enabled/disabled statuses are set.

@willkoch
Copy link
Contributor

Timestamps implemented (with wrapper in Simulation.cpp instead of S4U_Simulation.cpp) and JSON added for disk specific output. Disk timestamps disabled by default

@willkoch
Copy link
Contributor

Fixed formatting for all dumps. Closing now, not yet reflected on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants