Logs include color-changing ASCII codes even when logs are disabled

[henricasanova]

No description provided.

[henricasanova]

fixed.

[ryantanaka]

hey @henricasanova, so this issue refers to 5e840ff right?

In one of my activities, I run wrench like this:

CMD ./simulator_remote_storage 10 \
         --log="root.fmt:[%d][%h:%t]%e%m%n" \
         --log=root.thresh:critical \
         --log=wms.thresh:debug \
         --log=simple_wms.thresh:debug \
         --log=simple_wms_scheduler.thresh:debug

And I get no color. But, running ./simulator_remote_storage 10, I do get color in the terminal.

In the following functions, when I remove the nots, then I get the correct color always.

wrench/src/wrench/logging/TerminalOutput.cpp

Lines 41 to 57 in f3f10f7

	/**
	* @brief Turn on colored output for the calling process
	*/
	void TerminalOutput::beginThisProcessColor() {
	if ((not TerminalOutput::wrench_no_log) and (TerminalOutput::color_enabled)) {
	std::cerr << TerminalOutput::getThisProcessLoggingColor();
	}
	}
	/**
	* @brief Turn off colored output for the calling process
	*/
	void TerminalOutput::endThisProcessColor() {
	if ((not TerminalOutput::wrench_no_log) and (TerminalOutput::color_enabled)) {
	std::cerr << "\033[0m";
	}
	}

I want to make sure that change won't break anything else since I don't have any context for this issue.

Thanks!

[henricasanova]

Let me investigate.... seems that colors are broken a bit.

[henricasanova]

Just pushed a fix. Let me know if it addresses your bug.

[ryantanaka]

ok thanks, it works now

[henricasanova]

Reopened this issue because there is still a problem. The WRENCH logging is just a few macros above the XBT logging. For instance, WRENCH_INFO does:

• If colors are enabled, insert the "begin color" ASCII codes
• call XBT_INFO
• If colors are enabled, insert the "end color" ASCII codes

The problem is that if the user disables an xbt log category, the above still does steps #1 and #3. And the xbt log API does not provide an "am I enabled?" or "what's my priority?" API (it does have such functions, but they required the category name).

Henri will think of a solution.