Removed all @throw in comments as they were never used consistently /…

… correctly
wrench-project · Oct 10, 2024 · 80c9922 · 80c9922
1 parent 4517f62
commit 80c9922
Show file tree

Hide file tree

Showing 81 changed files with 3 additions and 1,409 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -266,7 +266,6 @@ set(SOURCE_FILES
         include/wrench/services/compute/batch/batch_schedulers/BatchScheduler.h
         include/wrench/services/compute/batch/batch_schedulers/homegrown/HomegrownBatchScheduler.h
         include/wrench/services/storage/storage_helpers/FileTransferThread.h
-        include/wrench/services/storage/storage_helpers/LogicalFileSystem.h
         include/wrench/services/storage/storage_helpers/LogicalFileSystemNoCaching.h
         include/wrench/services/storage/storage_helpers/LogicalFileSystemLRUCaching.h
         src/wrench/logging/TerminalOutput.cpp
@@ -372,9 +371,6 @@ set(SOURCE_FILES
         src/wrench/services/storage/storage_helper_classes/FileLocation.cpp
         src/wrench/services/storage/storage_helper_classes/FileTransferThread.cpp
         include/wrench/services/storage/storage_helpers/FileTransferThreadMessage.h
-        src/wrench/services/storage/storage_helper_classes/LogicalFileSystem.cpp
-        src/wrench/services/storage/storage_helper_classes/LogicalFileSystemNoCaching.cpp
-        src/wrench/services/storage/storage_helper_classes/LogicalFileSystemLRUCaching.cpp
         src/wrench/simgrid_S4U_util/S4U_Daemon.cpp
         src/wrench/simgrid_S4U_util/S4U_DaemonActor.cpp
         include/wrench/simgrid_S4U_util/S4U_DaemonActor.h

diff --git a/examples/action_api/XRootD/Controller.cpp b/examples/action_api/XRootD/Controller.cpp
@@ -73,7 +73,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int Controller::main() {
 

diff --git a/examples/action_api/bare-metal-bag-of-actions/TwoActionsAtATimeExecutionController.cpp b/examples/action_api/bare-metal-bag-of-actions/TwoActionsAtATimeExecutionController.cpp
@@ -44,7 +44,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int TwoActionsAtATimeExecutionController::main() {
         /* Initialize and seed a RNG */

diff --git a/examples/action_api/batch-bag-of-actions/GreedyExecutionController.cpp b/examples/action_api/batch-bag-of-actions/GreedyExecutionController.cpp
@@ -43,7 +43,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int GreedyExecutionController::main() {
         /* Initialize and seed a RNG */

diff --git a/examples/action_api/batch-mpi-action/BatchMPIActionController.cpp b/examples/action_api/batch-mpi-action/BatchMPIActionController.cpp
@@ -45,7 +45,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int BatchMPIActionController::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/action_api/cloud-bag-of-actions/GreedyExecutionController.cpp b/examples/action_api/cloud-bag-of-actions/GreedyExecutionController.cpp
@@ -45,7 +45,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int GreedyExecutionController::main() {
         /* Initialize and seed a RNG */

diff --git a/examples/action_api/communicating-custom-actions/CommunicatingActionsController.cpp b/examples/action_api/communicating-custom-actions/CommunicatingActionsController.cpp
@@ -44,7 +44,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int CommunicatingActionsController::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/action_api/job-action-failure/JobActionFailureController.cpp b/examples/action_api/job-action-failure/JobActionFailureController.cpp
@@ -43,7 +43,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int JobActionFailureController::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/action_api/multi-action-multi-job/MultiActionMultiJobController.cpp b/examples/action_api/multi-action-multi-job/MultiActionMultiJobController.cpp
@@ -45,7 +45,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int MultiActionMultiJobController::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/action_api/storage-service-proxy/Controller.cpp b/examples/action_api/storage-service-proxy/Controller.cpp
@@ -76,7 +76,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int Controller::main() {
 

diff --git a/examples/action_api/super-custom-action/SuperCustomActionController.cpp b/examples/action_api/super-custom-action/SuperCustomActionController.cpp
@@ -64,7 +64,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int SuperCustomActionController::main() {
         /* Set the logging output to GREEN */

diff --git a/...w_api/basic-examples/bare-metal-bag-of-tasks-programmatic-platform/TwoTasksAtATimeWMS.cpp b/...w_api/basic-examples/bare-metal-bag-of-tasks-programmatic-platform/TwoTasksAtATimeWMS.cpp
@@ -46,7 +46,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int TwoTasksAtATimeWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/bare-metal-chain-scratch/WorkflowAsAsingleJobWMS.cpp b/examples/workflow_api/basic-examples/bare-metal-chain-scratch/WorkflowAsAsingleJobWMS.cpp
@@ -44,7 +44,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int WorkflowAsAsingleJobWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/bare-metal-chain/OneTaskAtATimeWMS.cpp b/examples/workflow_api/basic-examples/bare-metal-chain/OneTaskAtATimeWMS.cpp
@@ -44,7 +44,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int OneTaskAtATimeWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/bare-metal-complex-job/ComplexJobWMS.cpp b/examples/workflow_api/basic-examples/bare-metal-complex-job/ComplexJobWMS.cpp
@@ -47,7 +47,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int ComplexJobWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/bare-metal-data-movement/DataMovementWMS.cpp b/examples/workflow_api/basic-examples/bare-metal-data-movement/DataMovementWMS.cpp
@@ -47,7 +47,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int DataMovementWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/bare-metal-multicore-tasks/OneTaskAtATimeWMS.cpp b/examples/workflow_api/basic-examples/bare-metal-multicore-tasks/OneTaskAtATimeWMS.cpp
@@ -41,7 +41,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int OneTaskAtATimeWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/batch-bag-of-tasks/TwoTasksAtATimeBatchWMS.cpp b/examples/workflow_api/basic-examples/batch-bag-of-tasks/TwoTasksAtATimeBatchWMS.cpp
@@ -46,7 +46,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int TwoTasksAtATimeBatchWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/batch-pilot-job/PilotJobWMS.cpp b/examples/workflow_api/basic-examples/batch-pilot-job/PilotJobWMS.cpp
@@ -45,7 +45,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int PilotJobWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/cloud-bag-of-tasks-energy/TwoTasksAtATimeCloudWMS.cpp b/examples/workflow_api/basic-examples/cloud-bag-of-tasks-energy/TwoTasksAtATimeCloudWMS.cpp
@@ -46,7 +46,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int TwoTasksAtATimeCloudWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/cloud-bag-of-tasks/TwoTasksAtATimeCloudWMS.cpp b/examples/workflow_api/basic-examples/cloud-bag-of-tasks/TwoTasksAtATimeCloudWMS.cpp
@@ -46,7 +46,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int TwoTasksAtATimeCloudWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/io-pagecache/ConcurrentPipelineWMS.cpp b/examples/workflow_api/basic-examples/io-pagecache/ConcurrentPipelineWMS.cpp
@@ -44,7 +44,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int ConcurrentPipelineWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/basic-examples/io-pagecache/NFSPipelineWMS.cpp b/examples/workflow_api/basic-examples/io-pagecache/NFSPipelineWMS.cpp
@@ -48,7 +48,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int NFSPipelineWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/.../basic-examples/virtualized-cluster-bag-of-tasks/TwoTasksAtATimeVirtualizedClusterWMS.cpp b/.../basic-examples/virtualized-cluster-bag-of-tasks/TwoTasksAtATimeVirtualizedClusterWMS.cpp
@@ -50,7 +50,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int TwoTasksAtATimeVirtualizedClusterWMS::main() {
         /* Set the logging output to GREEN */

diff --git a/examples/workflow_api/real-workflow-example/SimpleWMS.cpp b/examples/workflow_api/real-workflow-example/SimpleWMS.cpp
@@ -40,7 +40,6 @@ namespace wrench {
      *
      * @return 0 on completion
      *
-     * @throw std::runtime_error
      */
     int SimpleWMS::main() {
         TerminalOutput::setThisProcessLoggingColor(TerminalOutput::COLOR_GREEN);

diff --git a/include/wrench/services/compute/cloud/CloudComputeService.h b/include/wrench/services/compute/cloud/CloudComputeService.h
@@ -153,7 +153,6 @@ namespace wrench {
          * @param tosend: message to be sent
          * @return a simulation message
          *
-         * @throw std::runtime_error
          */
         std::shared_ptr<TMessageType> sendRequestAndWaitForAnswer(S4U_CommPort *answer_commport, ComputeServiceMessage *tosend) {
             serviceSanityCheck();