-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apriltag] Add AprilTagFieldLayout.loadField() and deprecate AprilTagFields.loadAprilTagLayoutField() #6331
Conversation
Also change AprilTagFields.loadFromResource() to use the new method
apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagFieldLayout.java
Outdated
Show resolved
Hide resolved
Java version looks good. Just needs a C++ port. |
This PR is technically breaking because now including |
I'd prefer there be only one obvious way to do it, so the old, more hidden way would be deprecated. I also dislike how the old function uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After internal discussion, we don't want to deprecate the function in the middle of the season. What we could do instead is merge this without the deprecation into main, then merge the deprecation on the development branch.
I don't know if it'd be easier (for when development and main are reconciled after the season) to a) merge #6377 and this PR separately into their respective branches or b) to merge #6377 into both and then have a different PR targeting development that's just the deprecation. For now I'm going with the separate PRs approach. (And side note, |
Closing in favor of #6550. |
Fixes #6326.
AprilTagFields.loadFromResource()
usesAprilTagFieldLayout.loadStandardField()
instead of the other way around so that it's easier for people to follow the call path. (Don't need to go to a different class)