Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Add Java and c++ finallyDo with zero-arg lambda #5862

Merged
merged 3 commits into from
Nov 3, 2023
Merged

[cmd] Add Java and c++ finallyDo with zero-arg lambda #5862

merged 3 commits into from
Nov 3, 2023

Conversation

shueja
Copy link
Contributor

@shueja shueja commented Nov 3, 2023 •
edited
Loading

Closes #5861

@shueja shueja requested a review from a team as a code owner November 3, 2023 17:05
@shueja
Copy link
Contributor Author

shueja commented Nov 3, 2023

The C++ overload would need a different function name.

@calcmogul
Copy link
Member

C++ can overload on the std::function type: https://godbolt.org/z/6fTfhj8P3

@shueja shueja changed the title [5861] Add Java and c++ finallyDo with zero-arg lambda [cmd] Add Java and c++ finallyDo with zero-arg lambda Nov 3, 2023
@PeterJohnson PeterJohnson merged commit 8a3a268 into wpilibsuite:main Nov 3, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzblue rzblue rzblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[commands] Add .finallyDo() that takes a zero-argument lambda
4 participants
@shueja @calcmogul @rzblue @PeterJohnson