Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java cmd] Fix CommandXboxController.leftTrigger() parameter order #5831

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[java cmd] Fix CommandXboxController.leftTrigger() parameter order #5831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6521bec
Fix CommandXboxController.leftTrigger() parameter order
rzblue Oct 26, 2023
f82dc91
Fix documentation order
rzblue Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/CommandXboxController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,13 @@ public Trigger back(EventLoop loop) {
* Constructs a Trigger instance around the axis value of the left trigger. The returned trigger
* will be true when the axis value is greater than {@code threshold}.
*
* @param loop the event loop instance to attach the Trigger to.
* @param threshold the minimum axis value for the returned {@link Trigger} to be true. This value
* should be in the range [0, 1] where 0 is the unpressed state of the axis.
* @param loop the event loop instance to attach the Trigger to.
* @return a Trigger instance that is true when the left trigger's axis exceeds the provided
* threshold, attached to the given event loop
*/
public Trigger leftTrigger(EventLoop loop, double threshold) {
public Trigger leftTrigger(double threshold, EventLoop loop) {
return m_hid.leftTrigger(threshold, loop).castTo(Trigger::new);
}

Expand All @@ -282,7 +282,7 @@ public Trigger leftTrigger(EventLoop loop, double threshold) {
* button loop}.
*/
public Trigger leftTrigger(double threshold) {
return leftTrigger(CommandScheduler.getInstance().getDefaultButtonLoop(), threshold);
return leftTrigger(threshold, CommandScheduler.getInstance().getDefaultButtonLoop());
}

/**
Expand Down