Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add udf test and refact csv test #9

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Conversation

lfkdsk
Copy link
Collaborator

@lfkdsk lfkdsk commented Oct 26, 2019

No description provided.

@lfkdsk lfkdsk self-assigned this Oct 26, 2019
Copy link
Owner

@wph95 wph95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for _, v := range pluginsMap[UDF] {
strs = append(strs, v.Name)
}
logutil.BgLogger().Info("Fuck PluginsMap", zap.Any("type", kind), zap.Strings("map", strs))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

儒雅随和
建议更换

@wph95 wph95 changed the base branch from engine/add-test to hackathon-2019 October 26, 2019 18:03
@wph95 wph95 merged commit 7b02f9e into hackathon-2019 Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants