-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for querying array type query data from blocks #176
Conversation
🦋 Changeset detectedLatest commit: c63f7ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
'preload' => 'auto', | ||
'src' => 'http://mysite.local/wp-content/uploads/2023/07/pexels_videos_1860684-1440p.mp4', | ||
'playsInline' => true, | ||
'controls' => null, | ||
'controls' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value of controls
is true
'caption' => '', | ||
'tracks' => [], | ||
'muted' => null, | ||
'caption' => null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caption is not set so its null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this new set of private methods, can we put the param/return types inside the function signatures instead of as doc-types?
Stricter types are always better in terms of tech-debt and extensibility.
Co-authored-by: John Parris <[email protected]>
Co-authored-by: John Parris <[email protected]>
Co-authored-by: John Parris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Dovid Levine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the major patch.
Description
Fixes: #61
How to Test
Screenshots