Bug Fix: Parsing boolean block attributes like in CoreVideo always return false.

[theodesp]

Description

Bug fix. Parsing boolean block attributes like in CoreVideo always return false.

Fixes: #135

Testing

1. Add a CoreVideo block in a Post and enable some of its checkbox settings for autoplay on the side.
2. Try to query the block attributes.
3. The boolean attributes should return the correct checked/unchecked value.

[changeset-bot]

🦋 Changeset detected

Latest commit: 06a633e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@wpengine/wp-graphql-content-blocks	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mindctrl]

LGTM. One suggestion to clarify the changelog entry.

[mindctrl]

I fixed the Sonarqube issue. It was complaining about the http URLs in the tests.

[justlevine]

Do we need to be concerned with other falsey values like an empty string?

Im not too familiar with the Block Attribute type validation, but WP is usually horrible at strict booleans.

[theodesp]

I think this is specifically targeted for empty strings. An empty string in the context of parsing a boolean attribute like
<video autoplay /> here autoplay="" which according to the HTML spec it's enabled. So in that case we return true. So unless the value is specifically false or null it is considered truthy.

[justlevine]

Remember that attributes here refer to all block attributes, and just not HTML attributes, so I wouldn't rely on that assumption that the underlying WordPress parser is making that distinction when it comes to the HTML spec.

Any while you've labeled this PR (and the associated test) as specific to CoreVideo, you're actually adding bool handling to all Block attributes plus passing them through helper libraries like DiDom.

It should be easy enough to test and confirm either way.

[theodesp]

I updated the code to handle null returns now. This should work as expected.