Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16: update lowest version of node to 18 since 16 is deprecating #1806

Merged
merged 4 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/calm-ears-appear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@faustwp/core': major
'@faustwp/cli': major
'@faustwp/blocks': major
'@faustwp/block-editor-utils': minor
---

BREAKING CHANGE: With the deprecation of node version 16.x and it no longer being maintained we have updated our engines and workflows to only use 18+. Please update to use node version 18+.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-next-example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
PR_BRANCH: ${{github.event.pull_request.head.ref}}
strategy:
matrix:
node: ['16', '18', '20']
node: ['18, '20]
defaults:
run:
working-directory: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-next-faustwp-example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
PR_BRANCH: ${{github.event.pull_request.head.ref}}
strategy:
matrix:
node: ['16', '18', '20']
node: ['18, '20]
defaults:
run:
working-directory: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-nightly-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
node: ['16', '18', '20']
node: ['18, '20]
defaults:
run:
working-directory: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test-plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'
- name: Install NPM Deps
run: |
npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '18'
- run: npm ci
- run: npm run build
- run: npm run lint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-22.04']
node: ['16', '18', '20']
node: ['18, '20]
permissions:
checks: write
pull-requests: write
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.15.0
v18.0.0
2 changes: 1 addition & 1 deletion examples/next/faustwp-getting-started/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"sass": "^1.54.9"
},
"engines": {
"node": ">=16",
"node": ">=18",
matthewguywright marked this conversation as resolved.
Show resolved Hide resolved
"npm": ">=8"
}
}
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@faustjs/root",
"private": true,
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
},
"workspaces": {
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
},
"homepage": "https://github.com/wpengine/faustjs#readme",
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
}
}
2 changes: 1 addition & 1 deletion packages/blocks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
"homepage": "https://github.com/wpengine/faustjs#readme",
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
}
}
2 changes: 1 addition & 1 deletion packages/faustwp-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
},
"homepage": "https://github.com/wpengine/faustjs#readme",
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
}
}
2 changes: 1 addition & 1 deletion packages/faustwp-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
},
"homepage": "https://github.com/wpengine/faustjs#readme",
"engines": {
"node": ">=16",
"node": ">=18",
"npm": ">=8"
}
}