-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merl 1256] Bug fix. Generate Autosave is missing from Post/Page Previews #1644
Conversation
🦋 Changeset detectedLatest commit: d6fbf56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
if (headerLink && headerLink.getAttribute('href') !== faustPreviewLink) { | ||
const clonedHeaderLink = headerLink.cloneNode(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theodesp I've tested this and both existing previews and draft previews no longer work for me. When requesting an existing post preview, the When requesting a new draft post, the |
@blakewilson I've updated the code. It should work now: Screen.Recording.2023-11-14.at.10.58.26.mp4 |
Lint error looks like relevant to this woocommerce/woocommerce-sniffs#34 Need to investigate |
I've realized this was due to a bug in Faust/Safari, so this may be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @theodesp! I've tested locally for published posts and draft posts and both work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comment about tests. Also there's a merge conflict now.
Apologies for accidentally closing this, typing in github and my focus jumped to |
Tasks
Description
Fixes missing call to
autosave
when clicking on the Preview links.Related Issue(s):
Testing
Screenshots
Documentation Changes
Dependant PRs