-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Set 404 Revalidate timer to 900 seconds. #1639
Conversation
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@theodesp You may want to update your testing instructions to mention that the user needs to also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add back the carrots to the example project's package.json
but other than that, this looks good to go! Nice work @theodesp
Tasks
Description
Sets the default ISR revalidate timer on 404 pages.
Closes #1580
Related Issue(s):
Testing
Cache-Control: s-maxage=900, stale-while-revalidate
Screenshots
Before
After
Documentation Changes
Dependant PRs