Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sprint blog post #1200

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Add sprint blog post #1200

merged 4 commits into from
Jan 4, 2023

Conversation

ChrisWiegman
Copy link
Contributor

Tasks

  • I've filled out the WP Engine Contributor License Agreement (CLA)

Description

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@ChrisWiegman ChrisWiegman requested a review from a team as a code owner January 4, 2023 13:55
@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6a385e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@headless-platform-by-wp-engine
Copy link

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-NOJIRA-23-01-blog-post https://hp…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

blakewilson
blakewilson reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@blakewilson blakewilson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisWiegman Nice! Just one small grammar suggestion.

internal/faustjs.org/blog/2023-01-04-faust-update-jan-04-2023.md Outdated Show resolved Hide resolved
@ChrisWiegman
Copy link
Contributor Author

Good catch, @blakewilson ! I've committed the fix

@headless-platform-by-wp-engine
Copy link

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-NOJIRA-23-01-blog-post https://hp…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

TeresaGobble
TeresaGobble reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@TeresaGobble TeresaGobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done Chris! I've added just three small suggestions. Thank you for writing this up for us!

internal/faustjs.org/blog/2023-01-04-faust-update-jan-04-2023.md Outdated Show resolved Hide resolved
internal/faustjs.org/blog/2023-01-04-faust-update-jan-04-2023.md Outdated Show resolved Hide resolved
internal/faustjs.org/blog/2023-01-04-faust-update-jan-04-2023.md
@@ -0,0 +1,18 @@
---
title: Faust Update - January 4, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our naming convention is currently Sprint ## Update - is this title an intentional deviation from that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm changing it for 2023 as "sprint" is confusing to some... not to mention we're back to sprint 1 which could get really confusing later this year.

@headless-platform-by-wp-engine
Copy link

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-NOJIRA-23-01-blog-post https://hp…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine
Copy link

Check out the recent updates to your Atlas preview environment:

App Environment URL Build
faustjs preview-env-NOJIRA-23-01-blog-post https://hp…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@ChrisWiegman ChrisWiegman merged commit 1c1069a into canary Jan 4, 2023
@ChrisWiegman ChrisWiegman deleted the NOJIRA-23-01-blog-post branch January 4, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeresaGobble TeresaGobble TeresaGobble left review comments

@blakewilson blakewilson blakewilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisWiegman @blakewilson @TeresaGobble