Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main <- canary #1123

Merged
merged 1 commit into from
Nov 2, 2022
Merged

main <- canary #1123

merged 1 commit into from
Nov 2, 2022

Conversation

blakewilson
Copy link
Contributor

No description provided.

@blakewilson
Telemetry notices (#1122)
27adca1 
* Add telemetry notice to faustjs.org site and update collected info list

* Add privacy policy to legacy faust site

* Add telemetry to sidebar

* Update docs site scripts for Atlas
@blakewilson blakewilson requested a review from a team as a code owner November 2, 2022 20:49
@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

⚠️ No Changeset found

Latest commit: 27adca1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

Coverage report for packages/core

St.❔
 Category Percentage Covered / Total
🟢 Statements 90.48% 304/336
🟢 Branches 84.83% 123/145
🟢 Functions 89.58% 43/48
🟢 Lines 90.33% 299/331

Test suite run success

61 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 27adca1

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

Coverage report for packages/next

St.❔
 Category Percentage Covered / Total
🟢 Statements 93.39% 240/257
🟢 Branches 82.04% 201/245
🟢 Functions 100% 33/33
🟢 Lines 93.39% 240/257

Test suite run success

55 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 27adca1

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

Coverage report for packages/faustwp-core

St.❔
 Category Percentage Covered / Total
🟢 Statements 89.03% 284/319
🟢 Branches 85.71% 126/147
🟢 Functions 87.23% 41/47
🟢 Lines 88.85% 279/314

Test suite run success

48 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 27adca1

TeresaGobble
TeresaGobble approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@TeresaGobble TeresaGobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work Blake!

@blakewilson blakewilson merged commit 3e38205 into main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeresaGobble TeresaGobble TeresaGobble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blakewilson @TeresaGobble