Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript race condition when registering wp-views in WP 5.6.1 #822

Open
joeyblake opened this issue Feb 16, 2021 · 1 comment
Open

Javascript race condition when registering wp-views in WP 5.6.1 #822

joeyblake opened this issue Feb 16, 2021 · 1 comment

Comments

@joeyblake
Copy link
Contributor

Using the classic editor, in WordPress 5.6.1, with concatenated scripts enabled, wp-tinymce.js includes the wp-view plugin. wp-tinymce does not wait for jQuery domready, and this causes wp-views to start initializing before shortcake views are registered. This results in existing shortcake shortcodes to not render in the editor on page load.

This can be fixed by moving the shortcode registration out of jQuery domready.

I have a fix for this coming in a few minutes.
@joeyblake joeyblake mentioned this issue Feb 16, 2021
Open
joeyblake added a commit to Knucklepuck/shortcake that referenced this issue Feb 16, 2021
@joeyblake
Moves sui shortcode registration outside of domready function to prev…
b87c4af 
…ent view race condition in WP 5.6.1

Fixes issue wp-shortcake#822
Also includes:
Update for node-sass to be compatible with OS X Big Sur
Updating a couple of deprecated jQuery functions
@krokodok
Copy link

Thaks Joey! I'm implementing this as a patch locally now in my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeyblake @krokodok