Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6959 UI issue after clear cache and apply LRC with certain template #7015

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Oct 7, 2024

Description

Fixes #6959

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check the issue #6959 for detailed scenario

Technical description

Documentation

Create a new function to avoid ui issues for elements with a specific styling

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal self-assigned this Oct 7, 2024
Copy link

codacy-production bot commented Oct 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 09708aa1 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (09708aa) Report Missing Report Missing Report Missing
Head commit (2307586) 37744 16585 43.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7015) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal requested a review from a team October 7, 2024 14:18
package.json Outdated Show resolved Hide resolved
@Miraeld Miraeld requested a review from a team October 8, 2024 01:23
@Mai-Saad Mai-Saad added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 9632180 Oct 10, 2024
13 checks passed
@Mai-Saad Mai-Saad deleted the fix/6959/ui-issue-lrc branch October 10, 2024 10:26
@Mai-Saad Mai-Saad self-requested a review October 10, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI issue after clear cache and apply LRC with certain template
3 participants