Adjust priority for rocket buffer

[Khadreal]

Description

Fixes wp-media/imagify-plugin#891

Type of change

• Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Check here for wp-media/imagify-plugin#893 (comment)

Technical description

Changed the priority of rocket buffer callbacks to 2/3 to fix the conflict issue with imagify image rewrite.

Documentation

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for a8997d91	❌ 0.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (a8997d9)	Report Missing	Report Missing	Report Missing
Head commit (e85cb61)	37744	16583	43.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7011)	2	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[remyperona]

Is this change necessary? With the change in Imagify it should not need to be modified on WP Rocket side

[Khadreal]

Is this change necessary? With the change in Imagify it should not need to be modified on WP Rocket side

Yes, it's necessary.
With the change in imagify, when you use the rocketcdn within wpr the issue still persists, this fix that.

[remyperona]

I'm worried about this change, as it could fix this specific case, but cause issues at the same time. The priority of features on rocket_buffer was specificly set to execute in the right order to avoid conflicts, so if we progress with this change, we will have to test every features and confirm they continue to work as expected.

[Khadreal]

Should we revert it as it wasn't part of the initial issues but found out it during test.
Also, when you look at the priority features, performance_hints happens before cdn.

[remyperona]

We can keep this open and do QA with the changes in Imagify & RocketCDN. If everything is good, we can close it, if QA report an issue related to it, we will see how to go with this one.

[Khadreal]

We can keep this open and do QA with the changes in Imagify & RocketCDN. If everything is good, we can close it, if QA report an issue related to it, we will see how to go with this one.

Please could you review it so we can move it to QA

[MathieuLamiot]

@Khadreal @wp-media/qa-team If we must first do QA on Imagify & RocketCDN PRs, just move this to ready for QA as theyr are reveiewed already and leave a comment explaining this properly in the issue.
You can even add the Imagify and RocketCDN PRs to the board if you want to track them individually.
Don't get blocked because of processes :)

[Khadreal]

@wp-media/qa-team please check the comments here