Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #6968 Add berlindb as dependency to composer #7008

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Oct 3, 2024

Description

Fixes #6968
Improve performance for site

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Update berlindb core from manually manage to being manage in composer

Technical description

Documentation

Add berlindb package to composer.json

New dependencies

Update Berlin DB

Risks

From the initial test perform by @Miraeld there are no risks, we still need to watch out for read-access restrictions on information_schema.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link

codacy-production bot commented Oct 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a8997d91 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a8997d9) Report Missing Report Missing Report Missing
Head commit (027aaed) 37744 16583 43.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7008) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal force-pushed the enhancement/6986-berlindb-update branch from e943fa1 to 84c31e0 Compare October 4, 2024 18:49
@Khadreal Khadreal changed the title closes #6968 closes #6968 Add berlindb as dependency to composer Oct 4, 2024
@remyperona remyperona marked this pull request as ready for review October 4, 2024 20:28
@remyperona remyperona requested a review from a team October 4, 2024 20:28
@remyperona remyperona added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement dev initiative labels Oct 4, 2024
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khadreal thank you for this PR.
Looking good on test env.
Test Run Results report below:
testrail-report-642.pdf

@remyperona remyperona added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit d99bce0 Oct 8, 2024
14 of 15 checks passed
@remyperona remyperona deleted the enhancement/6986-berlindb-update branch October 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev initiative type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up on BerlinDB update and questions
4 participants