Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6934: Beacon script is injected to logged-in users #6998

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Oct 1, 2024

Description

Fixes #6934

The beacon script will not be injected to logged-user that enables user cache.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

#6934 (comment)

Technical description

Documentation

We are checking if the user is logged-in and if the option user cache is enabled or not. If both returns true, then we are bailing out at the beacon injection to avoid it in the source code.

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld added the type: bug Indicates an unexpected problem or unintended behavior label Oct 1, 2024
@Miraeld Miraeld requested a review from a team October 1, 2024 10:55
@Miraeld Miraeld self-assigned this Oct 1, 2024
Copy link

codacy-production bot commented Oct 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 73488691 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7348869) Report Missing Report Missing Report Missing
Head commit (5e5bc82) 37744 16583 43.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6998) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected now

@Mai-Saad Mai-Saad added this pull request to the merge queue Oct 4, 2024
Merged via the queue into develop with commit 21c9f02 Oct 4, 2024
13 checks passed
@Mai-Saad Mai-Saad deleted the fix/6934-logged-user-with-cache-gets-beacon branch October 4, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beacon script is injected to logged-in users
4 participants