-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6887 Check for string to handle null return from get_permalink() #6996
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tabrisrp thank you for this PR. Looks good on test env.
Tests results report here:
testrail-report-640.pdf
Description
Fixes #6887
Prevent PHP fatal error when
get_permalink()
returnsnull
instead of a string. It should not happen by default but some plugins are doing that.Type of change
Detailed scenario
Explained in #6887
Technical description
Documentation
Use
is_string()
to make sure the$url
is a string before passing it to thedelete_by_url()
methodMandatory Checklist
Code validation
Code style
Additional Checks