Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6460 Maybe optimize lookups of tables in DB to stop using SHOW TABLES LIKE #6968

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Closes #6460 Maybe optimize lookups of tables in DB to stop using SHOW TABLES LIKE #6968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd2737
:closes: #6460 Modified lookup table query for improve performance
Khadreal Sep 11, 2024
e951e59
Fixed prepared statement error
Khadreal Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions inc/Engine/Common/Database/Queries/AbstractQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,9 +520,8 @@ protected function table_exists(): bool {
}

// Query statement.
$query = 'SHOW TABLES LIKE %s';
$like = $db->esc_like( $db->{$this->table_name} );
$prepared = $db->prepare( $query, $like );
$query = 'SELECT table_name FROM information_schema.tables WHERE table_name = %s LIMIT 1';
$prepared = $db->prepare( $query, $db->{$this->table_name} );
$result = $db->get_var( $prepared );

// Does the table exist?
Expand Down
5 changes: 2 additions & 3 deletions inc/Engine/Common/PerformanceHints/Database/Queries/AbstractQueries.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,8 @@ protected function table_exists(): bool {
}

// Query statement.
$query = 'SHOW TABLES LIKE %s';
$like = $db->esc_like( $db->{$this->table_name} );
$prepared = $db->prepare( $query, $like );
$query = 'SELECT table_name FROM information_schema.tables WHERE table_name = %s LIMIT 1';
$prepared = $db->prepare( $query, $db->{$this->table_name} );
$result = $db->get_var( $prepared );

// Does the table exist?
Expand Down
Loading