Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rollback version 3.16.4 #6897

Merged

Conversation

MathieuLamiot
Copy link
Contributor

@MathieuLamiot MathieuLamiot commented Aug 22, 2024

Description

Fixes #6893

Documentation

User documentation

On 3.17, users will be able to rollback to 3.16.4

image

Technical documentation

Changed WP_ROCKET_LASTVERSION

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).

New dependencies

NA

Risks

The rollback must be tested properly once the 3.17 release is ready.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@MathieuLamiot MathieuLamiot requested a review from a team August 22, 2024 19:24
@MathieuLamiot MathieuLamiot self-assigned this Aug 22, 2024
@MathieuLamiot MathieuLamiot linked an issue Aug 22, 2024 that may be closed by this pull request
@MathieuLamiot
Copy link
Contributor Author

To properly test this, we should await a release candidate, and then do the rollback from it. So it is not tested yet at this stage.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e7ecc2b1 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e7ecc2b) Report Missing Report Missing Report Missing
Head commit (ee4d993) 37957 14482 38.15%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6897) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@remyperona remyperona added this to the 3.17 milestone Aug 22, 2024
@Mai-Saad
Copy link
Contributor

Rollback from PR is working fine

@MathieuLamiot MathieuLamiot merged commit c6b849e into feature/lrc Aug 23, 2024
11 checks passed
@MathieuLamiot MathieuLamiot deleted the enhancement/6893-bump-rollback-version-3-16-4 branch August 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.17 - Bump rollback version
3 participants