Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #6289: Error Code when RUCSS can't be reached #6347

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Closes #6289: Error Code when RUCSS can't be reached #6347

merged 1 commit into from
Dec 28, 2023

Conversation

jeawhanlee
Copy link
Contributor

Description

This PR adds a default message when API response returns empty.

Fixes #6289

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: remove unused css labels Dec 21, 2023
@jeawhanlee jeawhanlee added this to the 3.15.7 milestone Dec 21, 2023
@jeawhanlee jeawhanlee self-assigned this Dec 21, 2023
@jeawhanlee jeawhanlee marked this pull request as ready for review December 21, 2023 06:48
@jeawhanlee jeawhanlee requested a review from a team December 21, 2023 06:48
@Mai-Saad
Copy link
Contributor

Related test plan https://wpmediaqa.testrail.io/index.php?/runs/view/796&group_by=cases:section_id&group_order=asc

@wordpressfan
Copy link
Contributor

Good to go with the following note:
Now SaaS returns error 500 with navigation timeout so it's failing without any retries.

testrail-report-554.pdf

@wordpressfan wordpressfan added this pull request to the merge queue Dec 28, 2023
Merged via the queue into develop with commit ff68d31 Dec 28, 2023
8 checks passed
@wordpressfan wordpressfan deleted the enhancement/6289-error-code-whenrucss-api-is-not-reached branch December 28, 2023 14:26
wordpressfan pushed a commit that referenced this pull request Mar 15, 2024
@jeawhanlee @wordpressfan
Closes #6289: Error Code when RUCSS can't be reached (#6347)
eb98fec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrochetFeve0251 CrochetFeve0251 CrochetFeve0251 left review comments

@wordpressfan wordpressfan wordpressfan approved these changes

@Miraeld Miraeld Miraeld approved these changes

Assignees

@jeawhanlee jeawhanlee

Labels
module: remove unused css type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.15.7
Development

Successfully merging this pull request may close these issues.

Error code when RUCSS API can't be reached
5 participants
@jeawhanlee @Mai-Saad @wordpressfan @Miraeld @CrochetFeve0251