Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock dynamiclists in integration tests #6126

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

engahmeds3ed
Copy link
Contributor

@engahmeds3ed engahmeds3ed commented Aug 30, 2023

Description

This is a dev initiative, to mock dynamic lists return in integration tests so our tests will not depend on the backend values and only depend on the values added by the plugin's code.

Fixes #6056

Type of change

Please delete options that are not relevant.

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@engahmeds3ed engahmeds3ed self-assigned this Aug 30, 2023
@engahmeds3ed engahmeds3ed marked this pull request as ready for review August 31, 2023 10:34
@engahmeds3ed engahmeds3ed added this pull request to the merge queue Aug 31, 2023
Merged via the queue into develop with commit fe36a3c Aug 31, 2023
@engahmeds3ed engahmeds3ed deleted the enhancement/6056-mock-dynamic-lists-in-tests branch August 31, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any change in dynamic lists may affect our tests
2 participants