Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix truncate rucss on wp-rocket options changes #6122

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

mostafa-hisham
Copy link
Contributor

@mostafa-hisham mostafa-hisham commented Aug 29, 2023

Description

change action name rocket_options_changed => rocket_domain_options_changed to avoid truncating rucss on options changes because this action rocket_options_changed is already used when we change options

Fixes #5667

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No gromming

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.

  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).

  • I validated all test plan the QA Review asked me to.

  • activate rucss and generate rucss fro some pages

  • change any wp-rocket option except the rucss safelist or deactivate rucss

  • rucss table (results) should not be truncated

@mostafa-hisham mostafa-hisham marked this pull request as ready for review August 29, 2023 05:10
@mostafa-hisham mostafa-hisham requested review from a team and CrochetFeve0251 August 29, 2023 05:10
@mostafa-hisham mostafa-hisham self-assigned this Aug 29, 2023
@piotrbak piotrbak added type: bug Indicates an unexpected problem or unintended behavior priority: high Issues which should be resolved as quickly as possible severity: major Feature is not working as expected and no work around available module: remove unused css labels Aug 29, 2023
@Mai-Saad Mai-Saad self-requested a review August 29, 2023 09:41
Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected (failed test due to issue on trunk)
testrail-report-519.pdf

@Mai-Saad Mai-Saad added this to the 3.15 milestone Aug 29, 2023
@engahmeds3ed engahmeds3ed added this pull request to the merge queue Aug 31, 2023
Merged via the queue into develop with commit 92330e8 Aug 31, 2023
@engahmeds3ed engahmeds3ed deleted the fix/truncate-rucss-on-wp-rocket-options-changes branch August 31, 2023 16:44
@engahmeds3ed engahmeds3ed mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: remove unused css priority: high Issues which should be resolved as quickly as possible severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a notice after a site was cloned to disable/re-enable WP Rocket
5 participants