Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #5927: Fatal Error UsedCSS::revert_to_pending() #6002

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Closes #5927: Fatal Error UsedCSS::revert_to_pending() #6002

merged 4 commits into from
Jun 23, 2023

Conversation

jeawhanlee
Copy link
Contributor

Description

Guards against parsing string to UsedCSS::revert_to_pending()

Fixes #5927

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

Automated tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jeawhanlee jeawhanlee added type: bug Indicates an unexpected problem or unintended behavior module: remove unused css labels Jun 21, 2023
@jeawhanlee jeawhanlee self-assigned this Jun 21, 2023
@jeawhanlee jeawhanlee marked this pull request as ready for review June 21, 2023 17:07
@jeawhanlee jeawhanlee requested a review from a team June 21, 2023 17:07
@vmanthos vmanthos self-requested a review June 23, 2023 05:38
vmanthos
vmanthos approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! 👍

@vmanthos vmanthos added this to the 3.14.1 milestone Jun 23, 2023
@vmanthos vmanthos added this pull request to the merge queue Jun 23, 2023
Merged via the queue into develop with commit c4d3c02 Jun 23, 2023
@vmanthos vmanthos deleted the fix/5927-fatal-error-usedcss branch June 23, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyperona remyperona remyperona approved these changes

@vmanthos vmanthos vmanthos approved these changes

Assignees

@jeawhanlee jeawhanlee

Labels
module: remove unused css type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.14.1
Development

Successfully merging this pull request may close these issues.

Fatal Error UsedCSS::revert_to_pending()
3 participants
@jeawhanlee @vmanthos @remyperona