Closes #5885: Preload: Don't try to preload private pages

[jeawhanlee]

Description

Checks for posts with private status and exclude from preload.

Fixes #5885

Type of change

• Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

Automated tests

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[Mai-Saad]

@jeawhanlee Thanks for the PR. Now adding new private post / editing content of existing private post won't add any entry in the cache table.

However, @piotrbak do you think we need to do change for any of the following?

1. if we edited public cached post to private, we won't remove the entry from the cache table till manual cache clear or change settings. can we delete the URL in this case?
2. if custom sitemap contains private URL, it will be added to the table then removed once processed.
3. if we edited private post, home, author (prev/next if not private) will be preloaded

[piotrbak]

@Mai-Saad 2 and 3 are okay.

For the first one, it's acceptable, but it would be better if we could remove that kind of post from the cache table directly. @jeawhanlee Is it doable without much complexity?

[jeawhanlee]

@Mai-Saad 2 and 3 are okay.

For the first one, it's acceptable, but it would be better if we could remove that kind of post from the cache table directly. @jeawhanlee Is it doable without much complexity?

@piotrbak We should be able to do that.

[piotrbak]

@jeawhanlee Please try to do that. If you have any troubles or feel it can introduce side effects, please ping me

[Mai-Saad]

@jeawhanlee Thanks for the updates. editing public post to private, is not sending any requests now.
However, we are sending requests to the URL in the following cases:
1- Update while having pending private post => When we remove the private URL from the cache table, we send a request (404)
2- While using a custom sitemap, containing private URLs => when we remove the private URL, we are sending a request (404)
can you please check?

[engahmeds3ed]

After a discussion with @jeawhanlee we agreed to make it more performant and use static variable to have the list of private urls not to get the list again with each url and instead of adding a new condition/login we will use the filter rocket_preload_exclude_urls to exclude all of those private posts urls.

[vmanthos]

Working as expected. 👍

TestRail report: testrail-report-496.pdf