Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #4541 Update tutorials categories and add new videos #4545

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

remyperona
Copy link
Contributor

Description

Update the tutorials categories, re-organize the videos and add the new ones about core web vitals

Fixes #4541

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

  • Checked the tutorials page after the changes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@remyperona remyperona added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement Module: dashboard module: user interface labels Nov 29, 2021
@remyperona remyperona added this to the 3.10.5 milestone Nov 29, 2021
@remyperona remyperona requested a review from a team November 29, 2021 15:59
@remyperona remyperona self-assigned this Nov 29, 2021
Copy link
Contributor

@iCaspar iCaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code point of view this is all good. Just wondering about the abbreviations mentioned below.

views/settings/page-sections/tutorials.php Show resolved Hide resolved
@remyperona remyperona requested a review from a team November 30, 2021 18:23
@Mai-Saad Mai-Saad self-requested a review December 1, 2021 06:01
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Dec 1, 2021

@Tabrisrp Please find notes/Qs below while exploring the PR:

  1. For Getting Started section, Can we adjust the cards so as not to have an empty card in between?
    videos

  2. Is it intended that controls for new videos are different from the old ones? , (I think better all be the same if doable, will vote for old ones controls)
    old:
    Screenshot from 2021-12-01 08-17-09
    new:
    Screenshot from 2021-12-01 08-17-51

  3. Can we guard against this console error, it happens once?
    Screenshot from 2021-12-01 08-16-14

  4. On trunk as well: is it intended that the closing icon be outside the video area?

  5. As a future enhancement: background images of videos better be homogenous (now old ones with text then dotted line below, new ones with icon & text below)

  6. Note: Before release, we need to ensure having the translation for new videos labels and new category titles

  7. On trunk: Just confirming that the same video (en version) is displayed independently on WP language

@Agathemed
Copy link

Is it intended that controls for new videos are different from the old ones? , (I think better all be the same if doable, will vote for old ones controls)

It looks like Wistia is doing that automatically because of chapters in the video. There was no changes in the styles for controls.

As a future enhancement: background images of videos better be homogenous (now old ones with text then dotted line below, new ones with icon & text below)

This is not new vs old, it's just a different thumbnail for Core Web Vitals videos. We are taking advantage of the illustration to explain the metric.

@remyperona
Copy link
Contributor Author

remyperona commented Dec 1, 2021

1: I pushed a CSS change for that
2, 3, 4, 5: that's all handled on Wistia side, not ours
6: Yes
7: Yes

Copy link
Contributor

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@remyperona remyperona merged commit 7cb98ad into develop Dec 2, 2021
@remyperona remyperona deleted the enhancement/4541-tutorials-tab branch December 2, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: dashboard module: user interface type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorials Tab - Reorganize and Add Videos
4 participants