Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4472 - Display notice when DelayJS is activated with Autoptimize Aggregate JS already in effect #4501

Merged
merged 19 commits into from
Nov 23, 2021
Merged

Fix 4472 - Display notice when DelayJS is activated with Autoptimize Aggregate JS already in effect #4501

merged 19 commits into from
Nov 23, 2021

Commits on Nov 12, 2021

  1. Add tests and method for AO agg-js and wpr delayjs

    @iCaspar
    iCaspar committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    4a2c99c View commit details
    Browse the repository at this point in the history

  2. Fix param order in docblock

    @iCaspar
    iCaspar committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b279d92 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Use add_settings_error instead of transient

    @iCaspar
    iCaspar committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a8b51e1 View commit details
    Browse the repository at this point in the history

  2. Fix docblock order

    @iCaspar
    iCaspar committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    138bbe4 View commit details
    Browse the repository at this point in the history

  3. Remove dead transient_errrors code

    @iCaspar
    iCaspar committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    75a7322 View commit details
    Browse the repository at this point in the history

  4. Remove extra spacing

    @iCaspar
    iCaspar committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    6b99789 View commit details
    Browse the repository at this point in the history

  5. Use matching priority in test

    @iCaspar
    iCaspar committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    44e9970 View commit details
    Browse the repository at this point in the history

  6. Remove using void thing.

    @iCaspar
    iCaspar committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e1c6031 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Move warning method to new Compat Subscriber

    @iCaspar
    iCaspar committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    2c83073 View commit details
    Browse the repository at this point in the history

  2. Reconfigure for new story conditions

    @iCaspar
    iCaspar committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    74659bf View commit details
    Browse the repository at this point in the history

  3. Add Autoptimize class to container

    @iCaspar
    iCaspar committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    6b7a55c View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Remove dead code from DelayJs Subscriber

    @iCaspar
    iCaspar committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    4240a87 View commit details
    Browse the repository at this point in the history

  2. Move test to ThirdParty

    @iCaspar
    iCaspar committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    b924a32 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Check failing test 

    This will display the notice as expected, but the integration test will not run in isolation. Other functions from preload still run on admin_notice.
    @iCaspar
    iCaspar committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0b65d66 View commit details
    Browse the repository at this point in the history

  2. Fix phpcs

    @iCaspar
    iCaspar committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    e3a3db1 View commit details
    Browse the repository at this point in the history

  3. Revise tests and make pass

    @iCaspar
    iCaspar committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    45b6cec View commit details
    Browse the repository at this point in the history

  4. Fix open/close strong tags

    @iCaspar
    iCaspar committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    b125877 View commit details
    Browse the repository at this point in the history

  5. Fix strong tags in test

    @iCaspar
    iCaspar committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    777de54 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Remove extra dismiss icon

    @iCaspar
    iCaspar committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    2c35105 View commit details
    Browse the repository at this point in the history