PHP Notice: Undefined property: stdClass::$table_name when enable database options on apache server

[Mai-Saad]

Describe the bug
When enabling database options and saving, many entries like this appear in debug.log
[11-Oct-2024 05:14:07 UTC] PHP Notice: Undefined property: stdClass::$table_name in /home/wpquicki/mega/avada/wp-content/plugins/wp-rocket/inc/Engine/Admin/Database/OptimizationProcess.php on line 131

To Reproduce
Steps to reproduce the behavior:

1. fresh install of WPR 3.17.1 or 3.17.0.2 on apache server i.e https://mega.wp-rocket.me/divi/
2. Enable database options and save
3. Check debug.log

Expected behavior
No undefined notice added to debug when enabling DB options at WPR

Desktop (please complete the following information):

• OS: Ubuntu
• Browser : Chrome Version 125.0.6422.141
• site https://mega.wp-rocket.me/divi/

Additional context
Add any other context about the problem here.

• not happening on ngnix server ex: e2e.rocketlabsqa.ovh
• slack thread https://wp-media.slack.com/archives/CUT7FLHF1/p1728624908143909

[piotrbak]

Related:
#5572

[Khadreal]

The query in

wp-rocket/inc/Engine/Admin/Database/OptimizationProcess.php

Line 127 in e780e82

$query = $wpdb->get_results( "SELECT table_name, data_free FROM information_schema.tables WHERE table_schema = '" . DB_NAME . "' and Engine <> 'InnoDB' and data_free > 0" );

is returning the column names in upper case(this is likely from the mysql/pdo setup of the server).
To solve this we can add an alias to the columns in the query.

[Khadreal]

Created a PR here for review

[Mai-Saad]

For testing:

• Please follow steps in the main issue and confirm that it's working fine on apache i.e mega/avada , ngnix i.e new.rocketlabsqa and multisite for both main and subsites (credentials on BW for mega multisite ) https://wpmediaqa.testrail.io/index.php?/cases/view/16694