Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials Tab Update - INP video #6997

Closed
Agathemed opened this issue Oct 1, 2024 · 2 comments · Fixed by #7087
Closed

Tutorials Tab Update - INP video #6997

Agathemed opened this issue Oct 1, 2024 · 2 comments · Fixed by #7087
Assignees
Labels
effort: [XS] < 1 day of estimated development time module: user interface noQA quick win type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@Agathemed
Copy link

Remove the FID video from the Core Web Vitals section and replace it with the INP one:

Title:
How to improve INP with WP Rocket

Video:
Available here(credentials available in bitwarden)

<script src="https://fast.wistia.com/embed/medias/s599wdduu1.jsonp" async></script><script src="https://fast.wistia.com/assets/external/E-v1.js" async></script><div class="wistia_responsive_padding" style="padding:56.25% 0 0 0;position:relative;"><div class="wistia_responsive_wrapper" style="height:100%;left:0;position:absolute;top:0;width:100%;"><span class="wistia_embed wistia_async_s599wdduu1 popover=true videoFoam=true" style="display:inline-block;height:100%;position:relative;width:100%">&nbsp;</span></div></div>

@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: user interface quick win labels Oct 1, 2024
@piotrbak
Copy link
Contributor

piotrbak commented Oct 1, 2024

Related past issue:
#4541

Video to be removed (replaced with the new, provided one):
image

@piotrbak piotrbak added the noQA label Oct 1, 2024
@Miraeld Miraeld self-assigned this Oct 21, 2024
@Miraeld
Copy link
Contributor

Miraeld commented Oct 21, 2024

Scope a solution

Pretty simple, here, change the key krqb7ckugp by s599wdduu1 & change the text to How to improve INP with WP Rocket
Should get this at the end:

			's599wdduu1' => __( 'How to improve INP with WP Rocket', 'rocket' ),

Effort

XS

@Miraeld Miraeld added the effort: [XS] < 1 day of estimated development time label Oct 21, 2024
@Miraeld Miraeld assigned Miraeld and unassigned Miraeld Oct 21, 2024
@piotrbak piotrbak added this to the 3.17.3 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time module: user interface noQA quick win type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants