OCI & LRC optimizations should not be applied, even if available, on SaaS visits

[MathieuLamiot]

Context
As part of #6944, we saw that on SaaS visits (?nowprocket=1&no_optimize=1&wpr_imagedimensions=1), LRC and OCI optimizations are applied if possible. This is not needed. We could save some CPU usage on this.

This is due to this line:

wp-rocket/inc/Engine/Common/PerformanceHints/Frontend/Subscriber.php

Line 44 in 8b030d3

'rocket_performance_hints_buffer' => [ 'maybe_apply_optimizations', 17 ],

Instead of running the whole maybe_apply_optimizations and therefore, maybe call the optimize methods of the factories, we should only maybe inject the beacon, and bypass the calls to optimize.

Expected behavior
On SaaS visits (?nowprocket=1&no_optimize=1&wpr_imagedimensions=1):

• if one of the PerformanceHints data is not in DB, then the beacon must be injected.
• otherwise, the beacon must not be added. the LRC and OCI optimization must not be applied.
  On visits with wpr_lazyrendercontent and not wpr_imagedimensions, the beacon must not be injected (already the case) and the LRC hashes must be added (already the case).

Acceptance Criteria
On a page with no data stored in DB for OCI/LRC:

• visit the normal page (no query string): hashes are added, beacon is injected.
• visit ?nowprocket=1&no_optimize=1&wpr_imagedimensions=1: hashes are added, beacon is injected.
• visit ?wpr_lazyrendercontent: hashes are added, beacon is not injected.

On a page with data stored in DB for OCI/LRC:

• visit the normal page (no query string): hashes are not, beacon not injected, OCI/LRC optimizations added..
• visit ?nowprocket=1&no_optimize=1&wpr_imagedimensions=1: hashes are not added, beacon is not injected, OCI/LRC optimizations not added.
• visit ?wpr_lazyrendercontent: hashes are added, beacon is not injected, OCI/LRC optimizations not added.

[Khadreal]

@MathieuLamiot the accepted criteria is what's currently happening or maybe I'm missing something here

[MathieuLamiot]

@Khadreal reproduced here: http://mathieu.e2e.rocketlabsqa.ovh/?nowprocket=1&no_optimize=1&wpr_imagedimensions=1

[Khadreal]

Grooming

in this method

wp-rocket/inc/Engine/Common/PerformanceHints/Frontend/Subscriber.php

Line 56 in 8b030d3

public function maybe_apply_optimizations( $html ): string {

we can add a logic check before optimization process begin, check if nowprocket && no_optimize && wpr_imagedimensions is set.

if( isset( $_GET['wpr_imagedimensions'] ) && isset( $_GET['no_optimize'] ) ) {
...
}
OR
if( isset( $_GET['wpr_imagedimensions'] ) && isset( $_GET['no_optimize'] ) && isset( $_GET['nowprocket'] )) {
...
}

Add same logic to add_hashes method here

wp-rocket/inc/Engine/Optimization/LazyRenderContent/Frontend/Controller.php

Line 129 in 8b030d3

public function add_hashes( $html ) {

Estimation

[S]

PS -- I think we can make the logic a method that can be reused for other sass visit, can't think of any at the moment.

[Miraeld]

Looks good to me.