Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.17 - Replace HTML Write operation from DOMDocument with Regex for LRC hash injection #6953

Closed
MathieuLamiot opened this issue Sep 5, 2024 · 0 comments · Fixed by #6954
Closed

3.17 - Replace HTML Write operation from DOMDocument with Regex for LRC hash injection #6953

MathieuLamiot opened this issue Sep 5, 2024 · 0 comments · Fixed by #6954
Assignees
@MathieuLamiot
Labels
needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped.
Milestone
3.17

Comments

@MathieuLamiot
Copy link
Contributor

Context
https://wp-media.slack.com/archives/CUT7FLHF1/p1725542573366859?thread_ts=1725532083.335009&cid=CUT7FLHF1

Expected behavior
For LRC, use DOMDocument to identify the opening tags in which a hash should be added. Then, use regexes to inject the hash attribute on the original HTML, so that DOMDocument output is only used on HTML exactly matching the original file.

Acceptance Criteria
@MathieuLamiot MathieuLamiot self-assigned this Sep 5, 2024
@MathieuLamiot MathieuLamiot added the needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. label Sep 5, 2024
@MathieuLamiot MathieuLamiot added this to the 3.17 milestone Sep 5, 2024
@MathieuLamiot MathieuLamiot mentioned this issue Sep 5, 2024
Merged
16 tasks
@MathieuLamiot MathieuLamiot linked a pull request Sep 5, 2024 that will close this issue
Fix/6953 lrc replace dom output with regex injection #6954
Merged
16 tasks
remyperona pushed a commit that referenced this issue Sep 11, 2024
@MathieuLamiot @Miraeld
Fixes #6953 LRC replace DOM output with regex injection (#6954)
2edb082 
Co-authored-by: Gael Robin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathieuLamiot MathieuLamiot

Labels
needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped.
Projects
None yet
Milestone
3.17
Development

Successfully merging a pull request may close this issue.

Fix/6953 lrc replace dom output with regex injection wp-media/wp-rocket
1 participant
@MathieuLamiot